Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version format of built packages #5197

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Fixed version format of built packages #5197

merged 1 commit into from
Jun 3, 2020

Conversation

harishsk
Copy link
Contributor

@harishsk harishsk commented Jun 3, 2020

Since we are no longer using the pre-release tag, our package versions at the daily build have had an improper version string with two hyphens in a row. This PR fixes that issue.
Our version format is not SemVer 2.0.0 compatible because according SemVer v2, the build metadata has to be separated by +. However this causes build warnings and attempting to fix the warnings causes the msbuild Pack task to not include build number in the package name.
That issue has to be resolved separately.

@harishsk harishsk requested a review from a team as a code owner June 3, 2020 00:24
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #5197 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5197      +/-   ##
==========================================
- Coverage   73.32%   73.31%   -0.01%     
==========================================
  Files        1007     1007              
  Lines      188386   187969     -417     
  Branches    20286    20241      -45     
==========================================
- Hits       138126   137809     -317     
+ Misses      44736    44634     -102     
- Partials     5524     5526       +2     
Flag Coverage Δ
#Debug 73.31% <ø> (-0.01%) ⬇️
#production 69.06% <ø> (+0.05%) ⬆️
#test 87.44% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
...rosoft.ML.Data/DataView/BatchDataViewMapperBase.cs 68.67% <0.00%> (-0.84%) ⬇️
...rosoft.ML.Data/DataView/RowToRowMapperTransform.cs 90.65% <0.00%> (-0.82%) ⬇️
...rosoft.ML.Data/Transforms/PerGroupTransformBase.cs 76.33% <0.00%> (-0.46%) ⬇️
...Microsoft.ML.Transforms/OptionalColumnTransform.cs 77.68% <0.00%> (-0.46%) ⬇️
...rc/Microsoft.ML.Data/Scorers/RowToRowScorerBase.cs 85.95% <0.00%> (-0.36%) ⬇️
src/Microsoft.ML.Data/Transforms/NAFilter.cs 85.77% <0.00%> (-0.31%) ⬇️
src/Microsoft.ML.Data/DataView/Transposer.cs 83.92% <0.00%> (-0.27%) ⬇️
...Microsoft.ML.Data/DataView/ArrayDataViewBuilder.cs 83.90% <0.00%> (-0.27%) ⬇️
...osoft.ML.Transforms/Text/TokenizingByCharacters.cs 86.34% <0.00%> (-0.25%) ⬇️
...Microsoft.ML.Transforms/SvmLight/SvmLightLoader.cs 95.45% <0.00%> (-0.25%) ⬇️
... and 28 more

@harishsk harishsk merged commit 0cbe115 into dotnet:master Jun 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants