Add a sample for Onnx conversion #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
reviewed
Jun 2, 2020
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Show resolved
Hide resolved
Lynx1820
reviewed
Jun 3, 2020
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Outdated
Show resolved
Hide resolved
Lynx1820
reviewed
Jun 3, 2020
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Outdated
Show resolved
Hide resolved
Lynx1820
reviewed
Jun 3, 2020
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Outdated
Show resolved
Hide resolved
Lynx1820
reviewed
Jun 3, 2020
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5195 +/- ##
=======================================
Coverage 73.31% 73.32%
=======================================
Files 1007 1007
Lines 188075 188124 +49
Branches 20244 20246 +2
=======================================
+ Hits 137892 137934 +42
- Misses 44658 44661 +3
- Partials 5525 5529 +4
|
harishsk
reviewed
Jun 4, 2020
docs/samples/Microsoft.ML.Samples/Dynamic/ModelOperations/OnnxConversion.cs
Show resolved
Hide resolved
harishsk
reviewed
Jun 8, 2020
| } | ||
|
|
||
| public static void Example() | ||
| { |
There was a problem hiding this comment.
I think this sample is getting more complicated than necessary. Can we simplify it just to demonstrate basic Onnx export and exporting to a different opset? The scenarios of using the whole pipeline versus partial pipeline is more advanced and can be left out of this sample. #Resolved
There was a problem hiding this comment.
harishsk
reviewed
Jun 8, 2020
| { | ||
| // Create data featurizing pipeline | ||
| var pipeline = mlContext.Transforms.CopyColumns("Label", "IsOver50K") | ||
| // Convert categorical features to one-hot vectors |
There was a problem hiding this comment.
Do you still need these changes? #Resolved
There was a problem hiding this comment.
yes, because the input data for the pipeline is raw data instead of featurizedData, and the onnx model can only be fed with raw data. So I refactor the SamplesDatasetUtils.cs to have a specific function to get raw data #Resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.