Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the graph is set to be the current graph when scoring with multiple models #5149

Merged
merged 3 commits into from
May 28, 2020

Conversation

frank-dong-ms-zz
Copy link
Contributor

Address issue: #4568

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #5149 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5149      +/-   ##
==========================================
- Coverage   75.79%   75.78%   -0.02%     
==========================================
  Files         993      993              
  Lines      181067   181077      +10     
  Branches    19494    19494              
==========================================
- Hits       137240   137227      -13     
- Misses      38532    38553      +21     
- Partials     5295     5297       +2     
Flag Coverage Δ
#Debug 75.78% <100.00%> (-0.02%) ⬇️
#production 71.68% <100.00%> (-0.02%) ⬇️
#test 88.92% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.TensorFlow/TensorflowTransform.cs 73.54% <100.00%> (+0.04%) ⬆️
...est/Microsoft.ML.Tests/TensorFlowEstimatorTests.cs 98.28% <100.00%> (+0.09%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 60.50% <0.00%> (-10.93%) ⬇️
...rosoft.ML.AutoML/Utils/SweepableParamAttributes.cs 47.89% <0.00%> (-4.21%) ⬇️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 59.60% <0.00%> (-2.65%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.47% <0.00%> (-0.85%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.10% <0.00%> (-0.16%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.58% <0.00%> (+0.32%) ⬆️

@frank-dong-ms-zz frank-dong-ms-zz marked this pull request as ready for review May 21, 2020 07:31
@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner May 21, 2020 07:31
@sharwell
Copy link
Member

I worry that this has the downside of making the TensorFlow API need to meet the compatibility requirements of the ML.NET API. This is particularly problematic for the Session type, which we know needs to be completely rewritten to follow managed resource rules.

@frank-dong-ms-zz
Copy link
Contributor Author

Thanks Sam, this is valid concern. What about can expose a new public method to let user reset default graph?


In reply to: 632123004 [](ancestors = 632123004)

Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is no longer making the Session variable as public, please update the title of the PR to reflect the solution.

@frank-dong-ms-zz frank-dong-ms-zz merged commit 3cd23c5 into dotnet:master May 28, 2020
@harishsk harishsk changed the title set Session as public so user can have access to tf graph Ensure that the graph is set to be the current graph when scoring with multiple models Jul 10, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants