Adding support for MurmurHash KeyDataTypes #5138
Merged
harishsk merged 3 commits intodotnet:masterfrom May 21, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5138 +/- ##
==========================================
+ Coverage 75.66% 75.68% +0.01%
==========================================
Files 990 990
Lines 179815 179867 +52
Branches 19342 19346 +4
==========================================
+ Hits 136061 136134 +73
+ Misses 38482 38464 -18
+ Partials 5272 5269 -3
|
Contributor
21ad377 to
cd62149
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ML.NET's behavior is to map zero input values to zero, instead of hashes.
TODO: rebase once other murmurhash PR are merged