-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when defining custom type for variables #5114
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5114 +/- ##
=========================================
Coverage ? 75.56%
=========================================
Files ? 995
Lines ? 179296
Branches ? 19295
=========================================
Hits ? 135488
Misses ? 38544
Partials ? 5264
|
Codecov Report
@@ Coverage Diff @@
## master #5114 +/- ##
=========================================
Coverage ? 75.80%
=========================================
Files ? 993
Lines ? 181169
Branches ? 19510
=========================================
Hits ? 137330
Misses ? 38535
Partials ? 5304
|
/azp run #Resolved |
Azure Pipelines successfully started running 2 pipeline(s). #Resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments. Also, as discussed offline, I think it'd be useful to add a test replicating the original scenario of the original issue, catching the exception, and actually checking that the exception is now the one you've introduced. Thanks 😄
resolve #4122
The unhelpful message stuff is a bit different from the above link's description. ML.NET throws unhelpful message not because the customer uses the wrong type(different from the type defined in onnx), but defining the variable using the same type as OnnxSequenceType. However, the correct type should be IEnumerable.
This change adds more information to existing exception message and adds a special error message for errors like this when customer carelessly defines a container variable without using container type