Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address TF test download fail, use resource manager with retry download #5102

Conversation

frank-dong-ms-zz
Copy link
Contributor

address below exception on OSX:

X Microsoft.ML.Scenarios.TensorFlowScenariosTests.TensorFlowTransforCifarEndToEndTest2 [1ms]
Error Message:
System.Net.WebException : Device not configured Device not configured
---- System.Net.Http.HttpRequestException : Device not configured
-------- System.Net.Sockets.SocketException : Device not configured
Stack Trace:
at System.Net.HttpWebRequest.GetResponse()
at System.Net.WebClient.GetWebResponse(WebRequest request)
at System.Net.WebClient.DownloadBits(WebRequest request, Stream writeStream)
at System.Net.WebClient.DownloadFile(Uri address, String fileName)
at System.Net.WebClient.DownloadFile(String address, String fileName)
at Microsoft.ML.Scenarios.TensorFlowScenariosTests.Download(String url, String destDir, String destFileName)

according to below issue and suggestion (The OSX resolve seems more fragile than other implementation), we retry download:
dotnet/runtime#30678

@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner May 7, 2020 01:11
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #5102 into master will decrease coverage by 0.00%.
The diff coverage is 91.07%.

@@            Coverage Diff             @@
##           master    #5102      +/-   ##
==========================================
- Coverage   75.62%   75.61%   -0.01%     
==========================================
  Files         993      993              
  Lines      178606   178501     -105     
  Branches    19201    19192       -9     
==========================================
- Hits       135066   134976      -90     
+ Misses      38307    38298       -9     
+ Partials     5233     5227       -6     
Flag Coverage Δ
#Debug 75.61% <91.07%> (-0.01%) ⬇️
#production 71.58% <ø> (+0.01%) ⬆️
#test 88.63% <91.07%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...cenariosWithDirectInstantiation/TensorflowTests.cs 91.56% <91.07%> (-0.32%) ⬇️
src/Microsoft.ML.OnnxTransformer/OnnxTypeParser.cs 64.36% <0.00%> (-0.88%) ⬇️
src/Microsoft.ML.OnnxConverter/OnnxContextImpl.cs 71.67% <0.00%> (-0.86%) ⬇️
...ata/Transforms/ValueToKeyMappingTransformerImpl.cs 82.79% <0.00%> (-0.28%) ⬇️
src/Microsoft.ML.Data/Transforms/KeyToVector.cs 83.65% <0.00%> (-0.19%) ⬇️
...ML.Data/Transforms/ValueToKeyMappingTransformer.cs 80.58% <0.00%> (-0.13%) ⬇️
...osoft.ML.OnnxTransformerTest/OnnxTransformTests.cs 97.38% <0.00%> (-0.10%) ⬇️
src/Microsoft.ML.Data/Transforms/KeyToValue.cs 81.81% <0.00%> (-0.05%) ⬇️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 99.33% <0.00%> (-0.04%) ⬇️
...L.AutoML/TrainerExtensions/TrainerExtensionUtil.cs 86.89% <0.00%> (ø)
... and 6 more

@frank-dong-ms-zz frank-dong-ms-zz merged commit 6c30763 into dotnet:master May 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants