Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vector tests for KeyToValue and ValueToKey #5090

Merged
merged 10 commits into from
May 8, 2020

Conversation

Lynx1820
Copy link
Contributor

@Lynx1820 Lynx1820 commented May 5, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #5090 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5090      +/-   ##
==========================================
- Coverage   75.66%   75.65%   -0.01%     
==========================================
  Files         993      993              
  Lines      178168   178170       +2     
  Branches    19122    19126       +4     
==========================================
- Hits       134802   134799       -3     
- Misses      38143    38146       +3     
- Partials     5223     5225       +2     
Flag Coverage Δ
#Debug 75.65% <100.00%> (-0.01%) ⬇️
#production 71.62% <100.00%> (-0.01%) ⬇️
#test 88.68% <100.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/Microsoft.ML.Data/Transforms/KeyToValue.cs 81.86% <100.00%> (+0.04%) ⬆️
...ML.Data/Transforms/ValueToKeyMappingTransformer.cs 80.65% <100.00%> (+0.06%) ⬆️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 99.29% <100.00%> (+<0.01%) ⬆️
test/Microsoft.ML.Tests/DatabaseLoaderTests.cs 91.17% <0.00%> (-2.91%) ⬇️
...L.AutoML/TrainerExtensions/TrainerExtensionUtil.cs 85.15% <0.00%> (-1.75%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 86.39% <0.00%> (-1.14%) ⬇️
.../Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs 82.09% <0.00%> (-0.12%) ⬇️
test/Microsoft.ML.TestFrameworkCommon/Datasets.cs 100.00% <0.00%> (ø)
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.13% <0.00%> (+0.20%) ⬆️
test/Microsoft.ML.Tests/TextLoaderTests.cs 96.08% <0.00%> (+0.54%) ⬆️
... and 2 more

@Lynx1820 Lynx1820 marked this pull request as ready for review May 5, 2020 23:35
@Lynx1820 Lynx1820 requested a review from a team as a code owner May 5, 2020 23:35
@harishsk
Copy link
Contributor

harishsk commented May 6, 2020

        {

nit: Please add a newline above.

But more importantly, ValueToKeyMapping (and related) transforms have caused a bunch of issues in Nimbus. Can you please run the Nimbus suite of tests and make sure that nothing is broken there as a result of these changes? #Resolved


Refers to: src/Microsoft.ML.Data/Transforms/ValueToKeyMappingTransformer.cs:813 in ebea3a0. [](commit_id = ebea3a0, deletion_comment = False)

@harishsk harishsk merged commit 59dbdea into dotnet:master May 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants