Skip to content

Update Onnx Convert documentation, limited to ONNX-ML target platforms #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Microsoft.ML/Models/OnnxConverter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@ public sealed partial class OnnxConverter
/// <see href="https://onnx.ai/">ONNX</see> is an intermediate representation format
/// for machine learning models. It is used to make models portable such that you can
/// train a model using a toolkit and run it in another tookit's runtime, for example,
/// you can create a model using ML.NET (or any ONNX compatible toolkit), convert it to ONNX and
/// then the ONNX model can be converted into say, CoreML, TensorFlow or WinML model
/// to run on the respective runtime.
/// you can create a model using ML.NET, export it to an ONNX-ML model file,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please clarify here what ONNX-ML is? May be add a line before that is a superset of ONNX and some explanation to its history.

/// then load and run that ONNX-ML model in Windows ML, on an UWP Windows 10 app.
///
/// This API converts an ML.NET model to ONNX format by inspecting the transform pipeline
/// This API converts an ML.NET model to ONNX-ML format by inspecting the transform pipeline
/// from the end, checking for components that know how to save themselves as ONNX.
/// The first item in the transform pipeline that does not know how to save itself
/// as ONNX, is considered the "input" to the ONNX pipeline. (Ideally this would be the
Expand Down