Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnetcore3.1 bench1 #5029

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Dotnetcore3.1 bench1 #5029

merged 3 commits into from
Apr 16, 2020

Conversation

frank-dong-ms-zz
Copy link
Contributor

@frank-dong-ms-zz frank-dong-ms-zz commented Apr 15, 2020 •
edited
Loading

allow tests to run on dotnet core 3.1:

  1. change back to Fact as some tests are passing on dotnet core 3.1
  2. change to use lower precision for dotnet core 3.1
  3. fix bug in baseline compare, when compare number with allowed precision, space and tab should not affect the result like below case:

they should be same if we set digitsOfPrecision = 3 (should remove space and tab which is only for format before compare result):

image

@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner April 15, 2020 22:37
harishsk
harishsk approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frank-dong-ms-zz frank-dong-ms-zz changed the title Dotnetcore3.1 branch1 Dotnetcore3.1 bench1 Apr 15, 2020
@frank-dong-ms-zz frank-dong-ms-zz merged commit a6fe47a into dotnet:master Apr 16, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harishsk harishsk harishsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frank-dong-ms-zz @harishsk @frank-dong-ms