Skip to content

disable test parallelization for ML.Test assembly to avoid crash #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2020
Merged

disable test parallelization for ML.Test assembly to avoid crash #4896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa477a9
disable test parallelization for ML.Test assembly to avoid crash
frank-dong-ms-zz Feb 26, 2020
e288840
refine comments
frank-dong-ms-zz Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/Microsoft.ML.Tests/DatabaseLoaderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ public void IrisVectorLightGbm()
}

[LightGBMFact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void IrisVectorLightGbmWithLoadColumnName()
{
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
Expand Down
2 changes: 0 additions & 2 deletions test/Microsoft.ML.Tests/FeatureContributionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ public void TestPoissonRegression()
}

[Fact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void TestGAMRegression()
{
TestFeatureContribution(ML.Regression.Trainers.Gam(), GetSparseDataset(numberOfInstances: 100), "GAMRegression");
Expand Down
2 changes: 0 additions & 2 deletions test/Microsoft.ML.Tests/OnnxConversionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,6 @@ public void TestVectorWhiteningOnnxConversionTest()
}

[Fact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void PlattCalibratorOnnxConversionTest()
{
var mlContext = new MLContext(seed: 1);
Expand Down
9 changes: 9 additions & 0 deletions test/Microsoft.ML.Tests/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Xunit;

// TODO: [TEST_STABILITY] disable test parallelization for this assembly as running test in parallel sometimes cause test host process to crash
[assembly: CollectionBehavior(DisableTestParallelization = true)]

Copy link
Contributor

@harishsk harishsk Feb 27, 2020 •
edited by frank-dong-ms-zz
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an additional tag after the TODO to help us search for tags associated with this work item. Say something like // TODO: TEST_STABILITY #Resolved

2 changes: 0 additions & 2 deletions test/Microsoft.ML.Tests/Scenarios/Api/CookbookSamples/CookbookSamplesDynamicApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,6 @@ public void GlobalFeatureImportance()
}

[Fact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void GetLinearModelWeights()
{
var dataPath = GetDataPath("housing.txt");
Expand Down
2 changes: 0 additions & 2 deletions test/Microsoft.ML.Tests/TrainerEstimators/TrainerEstimators.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ public void KMeansEstimator()
/// HogwildSGD TrainerEstimator test (logistic regression).
/// </summary>
[Fact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void TestEstimatorHogwildSGD()
{
var trainers = new[] { ML.BinaryClassification.Trainers.SgdCalibrated(l2Regularization: 0, numberOfIterations: 80),
Expand Down
4 changes: 0 additions & 4 deletions test/Microsoft.ML.Tests/TrainerEstimators/TreeEstimators.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ public void LightGBMBinaryEstimator()
}

[LightGBMFact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void LightGBMBinaryEstimatorUnbalanced()
{
var (pipe, dataView) = GetBinaryClassificationPipeline();
Expand All @@ -95,8 +93,6 @@ public void LightGBMBinaryEstimatorUnbalanced()
/// LightGBMBinaryTrainer CorrectSigmoid test
/// </summary>
[LightGBMFact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void LightGBMBinaryEstimatorCorrectSigmoid()
{
var (pipe, dataView) = GetBinaryClassificationPipeline();
Expand Down
2 changes: 0 additions & 2 deletions test/Microsoft.ML.Tests/Transformers/NormalizerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,8 +751,6 @@ public void GcnWorkout()
}

[Fact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void TestGcnNormCommandLine()
{
Assert.Equal(Maml.Main(new[] { @"showschema loader=Text{col=A:R4:0-10} xf=GcnTransform{col=B:A} in=f:\2.txt" }), (int)0);
Expand Down