fix netfx test not running issue #4862
Conversation
| @@ -23,7 +23,7 @@ | |||
| <VSTestLogger>trx</VSTestLogger> | |||
| <VSTestResultsDirectory>$(OutputPath)</VSTestResultsDirectory> | |||
| <AssemblyOriginatorKeyFile>$(ToolsDir)Test.snk</AssemblyOriginatorKeyFile> | |||
| <CopyLocalLockFileAssemblies>false</CopyLocalLockFileAssemblies> | |||
| <CopyLocalLockFileAssemblies Condition="'$(TargetFramework)' == 'netcoreapp3.0'">false</CopyLocalLockFileAssemblies> | |||
There was a problem hiding this comment.
I thought we set this to save on disk space. If we set this only for netcoreapp3.0 what happens to the diskspace usage on other platforms? #Resolved
There was a problem hiding this comment.
Yes, we only met disk issue on dotnet core 3.0 because of below setting from build tools:
false
false
true
for dotnet core 3.0 packages will copy to output folder by default and use extra 6-7 GB. So I set here to not copy packages to output, but this setting to false somehow affect test running for netfx 461 as below:
https://dev.azure.com/dnceng/public/_build/results?buildId=528701&view=logs&j=32952595-30e7-56fa-9b86-c4579b87f5d1
I'm not fully understand why this setting will affect test running on CI for netfx 461 as xunit seems not able to find any test to run but restrict this setting only for dotnet core 3.0 fix the disk issue also allow netfx 461 test to run on CI
In reply to: 382258052 [](ancestors = 382258052)
ghost
locked as resolved and limited conversation to collaborators
related to PR: #4854
setting CopyLocalLockFileAssemblies to false for netfx cause test not running on CI like below:
https://dev.azure.com/dnceng/public/_build/results?buildId=528701&view=logs&j=32952595-30e7-56fa-9b86-c4579b87f5d1
restrict CopyLocalLockFileAssemblies to false only for netcore 3.0