Skip to content

Fix grammatical typos #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2020
Merged

Fix grammatical typos #4853

merged 5 commits into from
Feb 19, 2020

Conversation

mstfbl
Copy link
Contributor

@mstfbl mstfbl commented Feb 18, 2020

Fix grammatical typos. Utilized Visual Studio Spell Checker to quickly find and implement typo fixes.

@mstfbl mstfbl requested a review from a team as a code owner February 18, 2020 23:11
@mstfbl mstfbl changed the title Fix grammatical typo Fix grammatical typos Feb 18, 2020
Copy link
Contributor

@gvashishtha gvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to ensure that these typo checks run as part of CI builds?

@mstfbl
Copy link
Contributor Author

mstfbl commented Feb 18, 2020

@gvashishtha Visual Studio Spell Checker actually marked certain correctly spelled words that are not in its dictionary as misspelled, so the human factor here is necessary to ascertain when the Spell Checker is correct or not. As such I don't think it would be realistically viable to have this as part of the CI build check.

@codemzs
Copy link
Member

codemzs commented Feb 18, 2020

@gvashishtha The point of this PR is to fix typos(see the title) not enable tests as part of CI build so blocking PR on it for that reason is not acceptable. @mstfbl feel free to dismiss the block.

@mstfbl mstfbl dismissed gvashishtha’s stale review February 18, 2020 23:55

Out of PR's scope

@mstfbl mstfbl merged commit 140cb70 into dotnet:master Feb 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants