Enable VSTHRD200 (Use "Async" suffix for async methods) #4794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
async-suffix
branch
from
830d006 to
a773496
Compare
sharwell
commented
Feb 14, 2020
| @@ -47,7 +47,7 @@ public interface IAsyncSweeper | |||
| /// Propose a <see cref="ParameterSet"/>. | |||
| /// </summary> | |||
| /// <returns>A future <see cref="ParameterSet"/> and its id. Null if unavailable or cancelled.</returns> | |||
| Task<ParameterSetWithId> Propose(); | |||
| Task<ParameterSetWithId> ProposeAsync(); | |||
There was a problem hiding this comment.
📝 This is the only public API change in this pull request. It's not clear to me if/when this API shipped or whether it's allowed to be renamed at this point. If we can't rename it, I'll revert the change to this file and use a suppression instead.
There was a problem hiding this comment.
Microsoft.ML.Sweeper hasn't shipped in any nuget package, so I think we are safe to rename this.
|
@harishsk This is now ready for review. Please make specific note of the indicated public API change. |
|
The changes have been approved. Can you please rebase and merge? |
This rule remains disabled in test code to avoid requiring test methods to be renamed.
This was referenced Apr 20, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule relies on a suppression analyzer (#4803) to avoid requiring test methods to be renamed.