Remove all spaces in the end of lines #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeahmed
reviewed
Jul 2, 2018
| @@ -37,7 +37,7 @@ public sealed partial class FastTreeTweedieTrainer : BoostingFastTreeTrainerBase | |||
| public const string LoadNameValue = "FastTreeTweedieRegression"; | |||
| public const string UserNameValue = "FastTree (Boosted Trees) Tweedie Regression"; | |||
| public const string Summary = "Trains gradient boosted decision trees to fit target values using a Tweedie loss function. This learner is a generalization of Poisson, compound Poisson, and gamma regression."; | |||
| new public const string Remarks = @"<remarks> | |||
| public new const string Remarks = @"<remarks> | |||
There was a problem hiding this comment.
Following the documentation, I see that keyword new is the first in statements. #Resolved
There was a problem hiding this comment.
Let me add real @TomFinley
RoboTom gives this:
warning TLC_ExplicitAccessModifiers: Symbol 'Remarks' did not have access modifiers as the leading modifiers
There was a problem hiding this comment.
The cold robotic hand of robotom was not programmed for this eventuality, due to the limitations of its flawed, human, designer. I might prefer to change robotom vs. do this.
There was a problem hiding this comment.
zeahmed
reviewed
Jul 3, 2018
| @@ -32,7 +32,7 @@ public sealed class PoissonRegression : LbfgsTrainerBase<Float, PoissonRegressio | |||
| internal const string UserNameValue = "Poisson Regression"; | |||
| internal const string ShortName = "PR"; | |||
| internal const string Summary = "Poisson Regression assumes the unknown function, denoted Y has a Poisson distribution."; | |||
| new internal const string Remarks = @"<remarks> | |||
| internal new const string Remarks = @"<remarks> | |||
There was a problem hiding this comment.
@Ivanidzo4ka, It has be reverted here as well...:)
I have opened PR (486) to fix it.
Closed
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
* remove all spaces in the end of lines
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to not have spaces in the end of lines