Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to capture test failures #4716

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Fix failure to capture test failures #4716

merged 1 commit into from
Jan 29, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jan 28, 2020 •
edited
Loading

Need to verify that this doesn't cause new test failures.

@sharwell sharwell marked this pull request as ready for review January 28, 2020 22:46
@sharwell sharwell requested a review from a team as a code owner January 28, 2020 22:46
frank-dong-ms-zz
frank-dong-ms-zz approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@frank-dong-ms-zz frank-dong-ms-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@harishsk harishsk merged commit 202642b into dotnet:master Jan 29, 2020
@sharwell sharwell deleted the capture-test-failures branch January 29, 2020 00:29
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frank-dong-ms-zz frank-dong-ms-zz frank-dong-ms-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @frank-dong-ms-zz @harishsk