-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update documentation to stop mentioning interfaces that no longer exist #4673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a095df9
ISchema to DataViewShema
antoniovs1029 12f0c5f
IRandom -> System.Random
antoniovs1029 bae0204
IRow -> DataViewRow
antoniovs1029 1cb8049
Moved DataViewRowCursor.md into docs/code
antoniovs1029 2e8d9e1
Moved DataViewRowCursor.md
antoniovs1029 505dcb6
Updated SynchronizedCursorBase
antoniovs1029 a8ea502
Updated ISchemaBindableMapper
antoniovs1029 43993bb
Updated ISweepers
antoniovs1029 eb7f5db
Updated RowCursorUtils
antoniovs1029 84bd5ce
Updated ClusteringEvaluator.Aggregator
antoniovs1029 e4cdafe
Updated EvaluatorBase
antoniovs1029 975aef4
Updated TrainerCursorBase
antoniovs1029 2c9b1d0
Updated OneToOneTransformBase
antoniovs1029 c2bc6b3
Updated KMeansUtils
antoniovs1029 c3b0ea2
Change in IDataReader code
antoniovs1029 45b3fc8
Modified ISweeper
antoniovs1029 b89a053
Revert "Updated SynchronizedCursorBase"
antoniovs1029 f8d549e
Use XML "see" for DataViewRow
antoniovs1029 e627874
Editing ClusteringEvaluator
antoniovs1029 5cf207e
Use XML "see" for DataViewRowCursor
antoniovs1029 925f52c
Updated RoleMappedSchema
antoniovs1029 cc9e55a
Updated ISchemaBindableMapper
antoniovs1029 2872752
Updated ISchemaBindableMapper
antoniovs1029 7229760
Remove MoveMany() comment from TrainerUtils
antoniovs1029 d15f0e6
Rephrase usage of "interface" on "Comparison with LINQ" Appendix
antoniovs1029 9286035
Typo
antoniovs1029 0f7a78d
Added explanatory comment to OneToOneTransformBase
antoniovs1029 77573fb
Updated IDataReader to IDataLoader in MlNetHighLevelConcepts.md
antoniovs1029 60f5891
Updated OneToOnetransformBase
antoniovs1029 fa6a364
Make it explicit that the Database loader spec refer to System.Data.I…
antoniovs1029 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see one usage of and various references to
IRowCursor
-- https://github.com/dotnet/machinelearning/search?utf8=%E2%9C%93&q=IRowCursor&type=Example:
machinelearning/src/Microsoft.ML.Data/Evaluators/BinaryClassifierEvaluator.cs
Line 1540 in 610ffcb
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it seems it is the only place in "actual code" where
IRowCursor
appears.It is wrapped inside a
#if !CORECLR
(link). So when building ML.NET nothing inside that block is compiled. If I remove the CORECLR if directive, then I get some errors, not only corresponding to the IRowCursor (which doesn't exist currently in ML.NET).I don't know if I should change it, then. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in
BinaryClassifierEvaluator
will not compile even if we changeIRowCursor
toDataViewRowCursor
, since it uses a class that does not exist in our code:XYPlot
. We had that class in an internal repo, and it used System.Windows.Forms which I believe is only for .Net Framework, so we didn't include it in ML.NET. I think that code can safely be deleted.In reply to: 368201681 [](ancestors = 368201681)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open another PR to remove that piece of code then, since I prefer that this PR remains only as changes in the documentation. Thanks for the clarification, @yaeldekel !
In reply to: 368281931 [](ancestors = 368281931,368201681)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened the PR in here: #4694
In reply to: 369266609 [](ancestors = 369266609,368281931,368201681)