Fix a bug with group Id column in CV macro and add NameColumn argument to CV and TrainTest macros #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
reviewed
Jul 2, 2018
| @@ -535,9 +535,9 @@ public float Cost | |||
| ch.Assert(groupColFieldType == typeof(string)); | |||
| var inputGroup = inputInstance.GetType().GetField(groupColField).GetValue(inputInstance); | |||
| if (group != (Optional<string>)inputGroup) | |||
| ch.Warning(warning, "group Id", label, inputGroup); | |||
| ch.Warning(warning, "group Id", group, inputGroup); | |||
There was a problem hiding this comment.
group [](start = 52, length = 5)
ugh.
Thank you finding this, and fixing it! #Resolved
Ivanidzo4ka
reviewed
Jul 2, 2018
| public Optional<string> GroupColumn = Optional<string>.Implicit(DefaultColumnNames.GroupId); | ||
|
|
||
| [Argument(ArgumentType.AtMostOnce, HelpText = "Name column name", ShortName = "name", SortOrder = 6)] |
There was a problem hiding this comment.
nit:
sort order is same for weight, kind, name, but 12 for group column. #Closed
Ivanidzo4ka
reviewed
Jul 2, 2018
| public Optional<string> GroupColumn = Optional<string>.Implicit(DefaultColumnNames.GroupId); | ||
|
|
||
| [Argument(ArgumentType.AtMostOnce, HelpText = "Name column name", ShortName = "name", SortOrder = 6)] |
There was a problem hiding this comment.
6 [](start = 110, length = 1)
should it be 13? #Closed
Ivanidzo4ka
reviewed
Jul 2, 2018
| return new MultiOutputRegressionMamlEvaluator(env, new MultiOutputRegressionMamlEvaluator.Arguments()); | ||
| default: | ||
| throw env.ExceptParam(nameof(kind), $"Trainer kind {kind} does not have an evaluator"); | ||
| case MacroUtils.TrainerKinds.SignatureBinaryClassifierTrainer: |
There was a problem hiding this comment.
[](start = 0, length = 12)
My VS put extra indent after "{" so if I format code, i get current formatting.
So next time if I happen to format this file, I'll revert your changes.
It's not a blocker, but maybe we need to discuss at some point default VS setting... #Closed
Ivanidzo4ka
reviewed
Jul 2, 2018
| public Optional<string> GroupColumn = Optional<string>.Implicit(DefaultColumnNames.GroupId); | ||
|
|
||
| [Argument(ArgumentType.AtMostOnce, HelpText = "Name column name", ShortName = "name", SortOrder = 6)] |
Ivanidzo4ka
reviewed
Jul 2, 2018
| if (name != (Optional<string>)inputName) | ||
| ch.Warning(warning, "name", name, inputName); | ||
| else | ||
| _inputBuilder.TrySetValue(nameColField, weight); |
There was a problem hiding this comment.
weight [](start = 60, length = 6)
name! #Closed
There was a problem hiding this comment.
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
…t to CV and TrainTest macros (dotnet#467) * Fix a bug with group Id column in CV macro * add NameColumn argument
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug #456, and also introduces a NameColumn argument to the TrainTest and CV macros, to enable the evaluator to use it in the per-instance results.
Fixes #456
Fixes #466