Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect crash dump, upload dump and pdb to artifact #4666

Merged
merged 2 commits into from
Jan 17, 2020
Merged

collect crash dump, upload dump and pdb to artifact #4666

merged 2 commits into from
Jan 17, 2020

Conversation

frank-dong-ms-zz
Copy link
Contributor

  1. collect crash dump when test host process crashes
  2. upload dump and pdb to artifact for further investigate

@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner January 16, 2020 19:57
safern
safern reviewed Jan 16, 2020
View reviewed changes
init-tools.cmd Show resolved Hide resolved
sharwell
sharwell reviewed Jan 16, 2020
View reviewed changes
init-tools.cmd Outdated Show resolved Hide resolved
sharwell
sharwell reviewed Jan 16, 2020
View reviewed changes
init-tools.cmd Outdated Show resolved Hide resolved
sharwell
sharwell requested changes Jan 16, 2020
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to restrict registry modifications to CI scenarios.

sharwell
sharwell approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually 👍

Not familiar with the syntax so someone else will need to check that part.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b045e4d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4666   +/-   ##
=========================================
  Coverage          ?   75.85%           
=========================================
  Files             ?      947           
  Lines             ?   172184           
  Branches          ?    18578           
=========================================
  Hits              ?   130603           
  Misses            ?    36409           
  Partials          ?     5172
Flag Coverage Δ
#Debug 75.85% <ø> (?)
#production 71.43% <ø> (?)
#test 90.71% <ø> (?)

@sharwell sharwell mentioned this pull request Jan 17, 2020
Closed
@frank-dong-ms-zz frank-dong-ms-zz merged commit 286c636 into dotnet:master Jan 17, 2020
@frank-dong-ms-zz frank-dong-ms-zz deleted the crashdump branch February 3, 2020 21:36
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@sharwell sharwell sharwell approved these changes

@harishsk harishsk Awaiting requested review from harishsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frank-dong-ms-zz @sharwell @safern @frank-dong-ms