Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally compile helper code #4534

Merged
merged 1 commit into from
Dec 8, 2019
Merged

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 6, 2019

Fixes IDE0051 (Private member is unused) in tests.

@sharwell sharwell requested a review from a team as a code owner December 6, 2019 22:43
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Fixes IDE0051 (Private member is unused) in tests.
@codecov
Copy link

codecov bot commented Dec 8, 2019

Codecov Report

Merging #4534 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4534      +/-   ##
==========================================
+ Coverage    75.1%   75.11%   +<.01%     
==========================================
  Files         908      908              
  Lines      160260   160245      -15     
  Branches    17259    17256       -3     
==========================================
+ Hits       120369   120373       +4     
+ Misses      35070    35055      -15     
+ Partials     4821     4817       -4
Flag Coverage Δ
#Debug 75.11% <ø> (ø) ⬆️
#production 70.51% <ø> (ø) ⬆️
#test 90.3% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
...est/Microsoft.ML.Predictor.Tests/TestPredictors.cs 67.94% <ø> (+0.98%) ⬆️
...L.AutoML/TrainerExtensions/TrainerExtensionUtil.cs 85.15% <0%> (-1.75%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.89% <0%> (+0.84%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 86.55% <0%> (+6.72%) ⬆️

@sharwell sharwell merged commit 5a763f6 into dotnet:master Dec 8, 2019
@sharwell sharwell deleted the conditional-code branch December 8, 2019 04:08
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants