Updating the DatabaseLoader to not force vector for single element columns #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC. @eerhardt, @CESARDELATORRE |
eerhardt
reviewed
Oct 29, 2019
| @@ -333,7 +333,14 @@ public Range(int min, int max) | |||
| internal static Range FromTextLoaderRange(TextLoader.Range range) | |||
| { | |||
| Contracts.Assert(range.Max.HasValue); | |||
| return new Range(range.Min, range.Max.Value); | |||
| if ((range.Max.Value == range.Min) && !range.ForceVector) | |||
There was a problem hiding this comment.
Another option might be:
Range result = new Range();
result.Min = range.Min;
result.Max = range.Max.Value;
result.ForceVector = range.ForceVector;
return result;It feels a little more straight forward than having to parse this if condition, and know which constructors will set ForceVector and which won't.
There was a problem hiding this comment.
I changed to the following as it allows some of the other asserts to be kept:
var dbRange = new Range(range.Min, range.Max.Value);
dbRange.ForceVector = range.ForceVector;
return dbRange;
eerhardt
approved these changes
Oct 29, 2019
eerhardt
approved these changes
Oct 29, 2019
frank-dong-ms-zz
pushed a commit
to frank-dong-ms-zz/machinelearning
that referenced
this pull request
Nov 4, 2019
…lumns (dotnet#4403) * Updating the DatabaseLoaderTests to cover a single load column * Updating the DatabaseLoader to not force vector for single element columns
frank-dong-ms-zz
pushed a commit
to frank-dong-ms-zz/machinelearning
that referenced
this pull request
Nov 4, 2019
…lumns (dotnet#4403) * Updating the DatabaseLoaderTests to cover a single load column * Updating the DatabaseLoader to not force vector for single element columns resolve conflict
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves dotnet/machinelearning-samples#722