Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release process documentation to README.md #4402

Merged
merged 12 commits into from
Jan 29, 2020

Conversation

gvashishtha
Copy link
Contributor

This PR better documents the release process for ML.NET

  • [ x ] There's a descriptive title that will make sense to other developers some time from now.
  • [ ] There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • [ x ] Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • [ x ] You have included any necessary tests in the same PR.

@gvashishtha gvashishtha requested a review from a team as a code owner October 28, 2019 18:17
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@codemzs
Copy link
Member

codemzs commented Nov 14, 2019

@gvashishtha This PR has been outstanding for a long time. If there are no imminent plans to check this in then I suggest we close this and revisit when it is ready to merged.

@gvashishtha
Copy link
Contributor Author

@codemzs please take a look at this, make sure it is consistent with our conversation today.

merging latest questions
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
| -------------|-------------|-------------|-------------|-------------|
| Nightly build| No change | No change | No change | No change |
| Monthly preview| No change | No change | No change | `preview` tag added, if this is the first preview, or preview index incremented (i.e. `A.B.C-preview` -> `A.B.C-preview2`) |
| GA releases | Possibly incremented for non-WIP NuGets | Incremented | Reset to 0 | `preview` tag is removed |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monthly releases can also be GA releases, like 1.4.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so in months when there is a monthly GA release, there is no monthly preview release? Like, when 1.4.0 came out, there was no 1.4-preview?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of preview releases is for our early adopters to preview new apis and features and give us feedback. So, ideally our GA releases should not include new apis and features and should mostly be bug fixes, doc updates, perf improvements and things like that. When we do that, there is no need for a preview release when we make a GA release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harishsk do let me know if the new version is good to go.

1. **Daily builds:** these can be downloaded from [this NuGet feed](https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=MachineLearning), and are built automatically each time a commit is made to the `master` branch.
1. **Preview:** These releases are built from the corresponding `A.B-preview-X` GitHub branch, and are expected to meet a higher quality bar than the daily builds. These can also be downloaded from [this NuGet feed](https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=MachineLearning), or within Visual Studio, as detailed below. When we introduce new API's in a preview release, we avoid doing a GA release at the same time (unless there are patches required for the last GA release). If there are no new API's, then we go straight to a GA release and skip the preview release.
1. **GA:** These releases are built from the corresponding `A.B` GitHub branch. They are rigorously tested, stable, and meant for general use. They are also the default choice when installing ML.NET via the `Install-Package Microsoft.ML` command.
1. **Fix:** These releases include patches for bugs in either the preview or GA releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that the GA releases are published to nuget.org and this should be good to go.

Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #4402 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4402      +/-   ##
==========================================
+ Coverage   75.84%   75.86%   +0.02%     
==========================================
  Files         951      951              
  Lines      172594   172435     -159     
  Branches    18632    18617      -15     
==========================================
- Hits       130896   130811      -85     
+ Misses      36523    36443      -80     
- Partials     5175     5181       +6
Flag Coverage Δ
#Debug 75.86% <0%> (+0.02%) ⬆️
#production 71.45% <0%> (-0.01%) ⬇️
#test 90.64% <0%> (+0.14%) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.OnnxConverter/OnnxContextImpl.cs 74.31% <0%> (-6.11%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <0%> (-3.37%) ⬇️
src/Microsoft.ML.Data/TrainCatalog.cs 82.11% <0%> (-1.84%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0%> (-0.85%) ⬇️
.../Microsoft.ML.Data/Prediction/CalibratorCatalog.cs 94.7% <0%> (-0.38%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.11% <0%> (-0.21%) ⬇️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 97.72% <0%> (-0.16%) ⬇️
...rc/Microsoft.ML.Data/Transforms/ColumnSelecting.cs 97.31% <0%> (-0.15%) ⬇️
.../Microsoft.ML.Vision/ImageClassificationTrainer.cs 88.83% <0%> (-0.15%) ⬇️
...ML.Tests/Scenarios/IrisPlantClassificationTests.cs 100% <0%> (ø) ⬆️
... and 27 more

Gopal Vashishtha added 4 commits January 24, 2020 09:10
@najeeb-kazmi
Copy link
Member

@gvashishtha can you please pull master so that the checks pass?

@gvashishtha gvashishtha merged commit 2aaa0f7 into dotnet:master Jan 29, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants