Skip to content

Move windows build machines to NetCorePublic-Pool. #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Move windows build machines to NetCorePublic-Pool. #4375

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57ff4e4
Move windows build machines to NetCorePublic-Pool.
codemzs Oct 24, 2019
cb610e3
PR feedback.
codemzs Oct 24, 2019
5ad77f7
PR feedback.
codemzs Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .vsts-dotnet-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ jobs:
name: Windows_x64_NetCoreApp21
buildScript: build.cmd
pool:
name: Hosted VS2017
name: NetCorePublic-Pool
queue: buildpool.windows.10.amd64.vs2017.open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead build on VS2019?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably doesn't matter either way. The only thing we use the VS on the machine for is the C++ compiler.

But if we wanted to update all of them to vs2019, that would be OK with me. But I don't think it is 100% required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ask because there has been discussions for corefx and other repos that we should be using the latest toolset to dogfood... but that can be done in a separate PR.


- template: /build/ci/job-template.yml
parameters:
Expand All @@ -81,12 +82,14 @@ jobs:
_config_short: RFX
_includeBenchmarkData: false
pool:
name: Hosted VS2017
name: NetCorePublic-Pool
queue: buildpool.windows.10.amd64.vs2017.open

- template: /build/ci/job-template.yml
parameters:
name: Windows_x86_NetCoreApp21
architecture: x86
buildScript: build.cmd
pool:
name: Hosted VS2017
name: NetCorePublic-Pool
queue: buildpool.windows.10.amd64.vs2017.open