Fix AutoML's reference to LightGbm #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoML has a reference to LightGbm, however it is getting the wrong version number in the dependency. Instead of `1.4.0-preview...`, it is getting `0.16.0-preview...`. This is because the casing in the reference is incorrect. Since the casing is incorrect, when evaluating the LightGbm project as a reference, its name no longer matches the casing in the `StableProjects` list, so it no longer thinks it is stable, and gets the unstable version. The fix is to fix the casing, and use case-insensitve checks when evaluating IsStableProject. Fix dotnet#4354
maryamariyan
approved these changes
Oct 21, 2019
LittleLittleCloud
approved these changes
Oct 21, 2019
|
Thank you! Great help |
Codecov Report
@@ Coverage Diff @@
## master #4358 +/- ##
==========================================
+ Coverage 74.59% 74.62% +0.02%
==========================================
Files 881 882 +1
Lines 154815 154848 +33
Branches 16910 16913 +3
==========================================
+ Hits 115486 115552 +66
+ Misses 34578 34548 -30
+ Partials 4751 4748 -3
|
frank-dong-ms-zz
pushed a commit
to frank-dong-ms-zz/machinelearning
that referenced
this pull request
Nov 4, 2019
AutoML has a reference to LightGbm, however it is getting the wrong version number in the dependency. Instead of `1.4.0-preview...`, it is getting `0.16.0-preview...`. This is because the casing in the reference is incorrect. Since the casing is incorrect, when evaluating the LightGbm project as a reference, its name no longer matches the casing in the `StableProjects` list, so it no longer thinks it is stable, and gets the unstable version. The fix is to fix the casing, and use case-insensitve checks when evaluating IsStableProject. Fix dotnet#4354
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoML has a reference to LightGbm, however it is getting the wrong version number in the dependency. Instead of
1.4.0-preview..., it is getting0.16.0-preview.... This is because the casing in the reference is incorrect.Since the casing is incorrect, when evaluating the LightGbm project as a reference, its name no longer matches the casing in the
StableProjectslist, so it no longer thinks it is stable, and gets the unstable version.The fix is to fix the casing, and use case-insensitve checks when evaluating IsStableProject.
Fix #4354