Skip to content

Build fix - removing the BOM from the CMakeLists.txt file (#430) #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Build fix - removing the BOM from the CMakeLists.txt file (#430) #431

merged 1 commit into from
Jun 27, 2018

Conversation

shauheen
Copy link
Contributor

Cherrypick internal build fix into release

* removing extraneous character that broke the linux build, and with it unecessary cmake version requirement

* Removing the BOM from the file
@shauheen shauheen requested review from eerhardt and sfilipi June 27, 2018 15:56
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shauheen and @sfilipi .

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell in GitHub that it has been removed. 😄

But this change fixed the build in master.

@eerhardt eerhardt merged commit ee19a42 into dotnet:release/preview Jun 27, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants