-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a LoadColumnNameAttribute #4308
Conversation
{ | ||
public int Label; | ||
|
||
[LoadColumnName("SepalLength", "SepalWidth")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand this. What if you have hundreds of columns to be loaded as a single vector. Do you need to specify all the column names? Can't you specify a column index range?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would it mean to have a name and range? Why not just use the more efficient index based LoadColumn attribute at that point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that's what I mean, to use the LoadColumn attribute for those cases. I was thinking about the LoadColumn
attribute. I didn't realize that here you are using LoadColumnName
, not the same attribute, ok. ;)
src/Microsoft.ML.Experimental/DataLoadSave/Database/LoadColumnNameAttribute.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoader.cs
Outdated
Show resolved
Hide resolved
This comment is now a bit out-of-date.
Refers to: src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoader.cs:240 in 90316ec. [](commit_id = 90316ec, deletion_comment = False) |
This comment is now a bit out-of-date.
Range can now be more than just indices. #Closed Refers to: src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoader.cs:253 in 90316ec. [](commit_id = 90316ec, deletion_comment = False) |
src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoaderCursor.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Experimental/DataLoadSave/Database/DatabaseLoader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Experimental/DataLoadSave/Database/LoadColumnNameAttribute.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4308 +/- ##
==========================================
- Coverage 74.57% 74.56% -0.02%
==========================================
Files 878 879 +1
Lines 154277 154524 +247
Branches 16874 16883 +9
==========================================
+ Hits 115058 115220 +162
- Misses 34472 34553 +81
- Partials 4747 4751 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This resolves #4195