Add DateTime to DateTime standard conversion. #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganik
approved these changes
Oct 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #4273 +/- ##
==========================================
+ Coverage 74.48% 74.57% +0.08%
==========================================
Files 877 878 +1
Lines 153663 154026 +363
Branches 16828 16852 +24
==========================================
+ Hits 114457 114863 +406
+ Misses 34474 34426 -48
- Partials 4732 4737 +5
|
codemzs
reviewed
Oct 2, 2019
| @@ -1673,5 +1674,9 @@ public void Convert(in TX src, ref SB dst) | |||
| public void Convert(in BL src, ref R8 dst) => dst = System.Convert.ToDouble(src); | |||
| public void Convert(in BL src, ref BL dst) => dst = src; | |||
| #endregion FromBL | |||
|
|
|||
| #region ToDT | |||
| public void Convert(in DT src, ref DT dst) => dst = src; | |||
There was a problem hiding this comment.
public void Convert(in DT src, ref DT dst) => dst = src; [](start = 8, length = 56)
Does not have test coverage as per https://codecov.io/gh/dotnet/machinelearning/pull/4273/diff #Closed
There was a problem hiding this comment.
Added a unit test for the new DateTime to DateTime conversion method.
In reply to: 330341048 [](ancestors = 330341048)
There was a problem hiding this comment.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error which is caused by a missing DateTime to DateTime conversion when outputting DateTime columns in NimbusML. NimbusML calls in to
RowCursorUtils.GetGetterAsCore(indirectly) which tries to find a conversion from DateTime to DateTime and fails with the following error:Error: *** System.InvalidOperationException: 'No standard conversion from 'DateTime' to 'DateTime'