Implement ONNX conversion for TypeConverting transform #4155
Conversation
|
@ganik do you want this to be part of preview release? #Resolved |
|
@ganik Please add tests that create a graph and output json file to compare against a baseline. #Resolved |
|
@codemzs, Can the test come in as part of another PR? I can use this PR for my work. Can this be merged once the tests pass? #Resolved |
|
no, I am not in hurry, will add tests In reply to: 526321188 [](ancestors = 526321188) |
| var key = (KeyDataViewType)_types[iinfo].GetItemType(); | ||
| node.AddAttribute("max", key.Count); | ||
| } | ||
| var t = _parent._columns[iinfo].OutputKind.ToInternalDataKind().ToType(); |
There was a problem hiding this comment.
var t [](start = 16, length = 6)
Need to handle key type #Resolved
|
@harishsk Please clone @ganik 's repo locally and unblock yourself. Thanks, @ganik for adding tests, they should be pretty straightforward, we have few examples that you can replicate and feel free to ask me if you need any help as I have written all of ONNX converter infrastructure and even tests ... I'm not asking for tests that also run on ORT (though that would be great), just a json file test that compares against the baseline would suffice. #Resolved |
|
I should add a note about the last commit I submitted. |
ghost
locked as resolved and limited conversation to collaborators
4 participants
fixes #4004
Tests TBD.