Skip to content

Load TransformerChain model file in ModelFileUtils #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

najeeb-kazmi
Copy link
Member

@najeeb-kazmi najeeb-kazmi commented Aug 13, 2019

Fixes #4109

Related to microsoft/NimbusML#201

Enables loading TransformerChain models from entrypoints. This is needed so that models trained in ML.NET can be scored in NimbusML.

NimbusML models could be loaded and scored in ML.NET, but we never tested it the other way around.

@najeeb-kazmi najeeb-kazmi requested review from eerhardt and ganik August 13, 2019 23:32
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this scenario?

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @najeeb-kazmi!

@ganik ganik merged commit ec9d92c into dotnet:master Aug 20, 2019
@najeeb-kazmi najeeb-kazmi deleted the 4109 branch January 30, 2020 01:24
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable loading TransformerChain models in EntryPoint graphs
3 participants