Farewell to the Static API #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were you thinking of removing references to dynamic API? and just renaming it to API? |
codemzs
reviewed
Jul 16, 2019
....ML.Samples/Dynamic/Transforms/TreeFeaturization/FastForestBinaryFeaturizationWithOptions.cs
Outdated
Show resolved
Hide resolved
|
I can do it in this PR or in another PR. It might be a more documentation focused PR, so I was not thinking to have in this PR initially. What do you think? In reply to: 512006889 [](ancestors = 512006889) |
eerhardt
reviewed
Jul 17, 2019
eerhardt
reviewed
Jul 17, 2019
eerhardt
reviewed
Jul 17, 2019
natke
approved these changes
Jul 26, 2019
eerhardt
reviewed
Jul 30, 2019
| @@ -73,11 +72,6 @@ | |||
| </None> | |||
| <PackageReference Include="Microsoft.ML.TensorFlow.Redist" Version="0.10.0" /> | |||
|
|
|||
| <ProjectReference Include="..\..\..\src\Microsoft.ML.Analyzer\Microsoft.ML.Analyzer.csproj"> | |||
There was a problem hiding this comment.
Why this change?
Nevermind, I see that we are removing the analyzer because it doesn't analyze anything other than static API usage.
|
Thank you for reviewing! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3952.
In this PR I 1. remove the static API code and 2. migrate the tests to the C# API (dynamic API) and 3. stop producing the static pipe nugets.
The commits are organized logically, which should simplify the review process.