Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatting Test, Projection and TimeSeries of Transform to Width 85 #3947

Merged
merged 3 commits into from
Jul 3, 2019

Conversation

rayankrish
Copy link

Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together

Fix for issue #3478

foreach (var row in column)
Console.WriteLine($"{string.Join(" ", row.DenseValues().Select(x => x.ToString("f3")))} ");
Console.WriteLine(string.Join(" ", row.DenseValues().Select(x =>
x.ToString("f3")))+" ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctrl+k+d is your friend.

Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

prediction) =>

Console.WriteLine("{0}\t{1}\t{2:0.00}\t{3:0.00}", value, prediction
.Prediction[0], prediction.Prediction[1], prediction.Prediction[2]);
Copy link
Contributor

@sierralee51 sierralee51 Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

prediction) =>
Console.WriteLine("{0}\t{1}\t{2:0.00}\t{3:0.00}\t{4:0.00}", value,
prediction.Prediction[0], prediction.Prediction[1],
prediction.Prediction[2], prediction.Prediction[3]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second "prediction" line too far indented?

@rayankrish rayankrish merged commit 1288d1d into dotnet:master Jul 3, 2019
@rayankrish rayankrish deleted the transform85-2 branch July 3, 2019 00:06
Dmitry-A pushed a commit to Dmitry-A/machinelearning that referenced this pull request Jul 24, 2019
…dotnet#3947)

* transform/text and projection formatted to 85 char

* transforms/timeseries formatted to 85 char

* minor tab and spacing fixes
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants