Internalize tensorflow API and sanity check APIs from Microsoft.ML.Tensorflow nuget #3936
Conversation
| @@ -105,7 +105,7 @@ public TensorFlowEstimator ScoreTensorFlowModel(string[] outputColumnNames, stri | |||
| /// <remarks> | |||
| /// The support for retraining is experimental. | |||
| /// </remarks> | |||
| public TensorFlowEstimator RetrainTensorFlowModel( | |||
| internal TensorFlowEstimator RetrainTensorFlowModel( | |||
There was a problem hiding this comment.
That was a pretty useful feature to have: being able to retrain existing graphs. Why do you want to remove it?
There was a problem hiding this comment.
As per @eerhardt "TensorFlowModel contains the most important method of the component - ScoreTensorFlowModel. However, it also contains a RetrainTensorFlowModel whose documentation say it is "experimental:...I think it is confusing to have an "experimental" API on the same class as a stable API."
We can always add it back and we are switching to TF.NET where we will enable this functionality anyways. It is easier to add things than to add then remove and modify.
There was a problem hiding this comment.
Ok makes sense. Maybe we could either:
- Write an issue about it.
- Add it as an extension to a preview API nuget (such as the experimental nuget)
There was a problem hiding this comment.
sounds good, i'll open an issue.
ghost
locked as resolved and limited conversation to collaborators
fixes #3863