-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightGBM Unbalanced Data Argument [Issue #3688 Fix] #3925
Merged
rayankrish
merged 12 commits into
dotnet:master
from
rayankrish:LightGBM-unbalanced-data
Jul 1, 2019
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2e709ce
LightGBM unbalanced data arg added
34dc2e7
unbalanced data argument added
785f52a
tests for unbalanced LightGbm and added arg for multiclass
14f0fdf
Merge branch 'master' of https://github.com/dotnet/machinelearning in…
370f09d
reverted changes on LightGbmArguments
1984dda
wording improvement on unbalanced arg help text
e6315e7
updated manifest
85f26dc
removed empty line
46210d4
Merge branch 'master' of https://github.com/dotnet/machinelearning
c97dd45
added keytype to test
26d978c
Merge remote-tracking branch 'origin/LightGBM-unbalanced-data' into L…
481c1b9
Merge branch 'master' of https://github.com/RadicalRayan/machinelearn…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,6 +55,28 @@ public void LightGBMBinaryEstimator() | |
NumberOfLeaves = 10, | ||
NumberOfThreads = 1, | ||
MinimumExampleCountPerLeaf = 2, | ||
UnbalancedSets = false, // default value | ||
}); | ||
|
||
var pipeWithTrainer = pipe.Append(trainer); | ||
TestEstimatorCore(pipeWithTrainer, dataView); | ||
|
||
var transformedDataView = pipe.Fit(dataView).Transform(dataView); | ||
var model = trainer.Fit(transformedDataView, transformedDataView); | ||
Done(); | ||
} | ||
|
||
[LightGBMFact] | ||
public void LightGBMBinaryEstimatorUnbalanced() | ||
{ | ||
var (pipe, dataView) = GetBinaryClassificationPipeline(); | ||
|
||
var trainer = ML.BinaryClassification.Trainers.LightGbm(new LightGbmBinaryTrainer.Options | ||
{ | ||
NumberOfLeaves = 10, | ||
NumberOfThreads = 1, | ||
MinimumExampleCountPerLeaf = 2, | ||
UnbalancedSets = true, | ||
}); | ||
|
||
var pipeWithTrainer = pipe.Append(trainer); | ||
|
@@ -322,6 +344,44 @@ public void LightGbmMulticlassEstimatorCorrectSigmoid() | |
Done(); | ||
} | ||
|
||
/// <summary> | ||
/// LightGbmMulticlass Test of Balanced Data | ||
/// </summary> | ||
[LightGBMFact] | ||
public void LightGbmMulticlassEstimatorBalanced() | ||
{ | ||
var (pipeline, dataView) = GetMulticlassPipeline(); | ||
|
||
var trainer = ML.MulticlassClassification.Trainers.LightGbm(new LightGbmMulticlassTrainer.Options | ||
{ | ||
UnbalancedSets = false | ||
}); | ||
|
||
var pipe = pipeline.Append(trainer) | ||
.Append(new KeyToValueMappingEstimator(Env, "PredictedLabel")); | ||
TestEstimatorCore(pipe, dataView); | ||
Done(); | ||
} | ||
|
||
/// <summary> | ||
/// LightGbmMulticlass Test of Unbalanced Data | ||
/// </summary> | ||
[LightGBMFact] | ||
public void LightGbmMulticlassEstimatorUnbalanced() | ||
{ | ||
var (pipeline, dataView) = GetMulticlassPipeline(); | ||
|
||
var trainer = ML.MulticlassClassification.Trainers.LightGbm(new LightGbmMulticlassTrainer.Options | ||
{ | ||
UnbalancedSets = true | ||
}); | ||
|
||
var pipe = pipeline.Append(trainer) | ||
.Append(new KeyToValueMappingEstimator(Env, "PredictedLabel")); | ||
TestEstimatorCore(pipe, dataView); | ||
Done(); | ||
} | ||
|
||
// Number of examples | ||
private const int _rowNumber = 1000; | ||
// Number of features | ||
|
@@ -338,7 +398,7 @@ private class GbmExample | |
public float[] Score; | ||
} | ||
|
||
private void LightGbmHelper(bool useSoftmax, double sigmoid, out string modelString, out List<GbmExample> mlnetPredictions, out double[] lgbmRawScores, out double[] lgbmProbabilities) | ||
private void LightGbmHelper(bool useSoftmax, double sigmoid, out string modelString, out List<GbmExample> mlnetPredictions, out double[] lgbmRawScores, out double[] lgbmProbabilities, bool unbalancedSets = false) | ||
{ | ||
// Prepare data and train LightGBM model via ML.NET | ||
// Training matrix. It contains all feature vectors. | ||
|
@@ -372,7 +432,9 @@ private void LightGbmHelper(bool useSoftmax, double sigmoid, out string modelStr | |
MinimumExampleCountPerGroup = 1, | ||
MinimumExampleCountPerLeaf = 1, | ||
UseSoftmax = useSoftmax, | ||
Sigmoid = sigmoid // Custom sigmoid value. | ||
Sigmoid = sigmoid, // Custom sigmoid value. | ||
UnbalancedSets = unbalancedSets // false by default | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Empty line. |
||
}); | ||
|
||
var gbm = gbmTrainer.Fit(dataView); | ||
|
@@ -583,6 +645,35 @@ public void LightGbmMulticlassEstimatorCompareSoftMax() | |
Done(); | ||
} | ||
|
||
[LightGBMFact] | ||
public void LightGbmMulticlassEstimatorCompareUnbalanced() | ||
{ | ||
// Train ML.NET LightGBM and native LightGBM and apply the trained models to the training set. | ||
LightGbmHelper(useSoftmax: true, sigmoid: .5, out string modelString, out List<GbmExample> mlnetPredictions, out double[] nativeResult1, out double[] nativeResult0, unbalancedSets:true); | ||
|
||
// The i-th predictor returned by LightGBM produces the raw score, denoted by z_i, of the i-th class. | ||
// Assume that we have n classes in total. The i-th class probability can be computed via | ||
// p_i = exp(z_i) / (exp(z_1) + ... + exp(z_n)). | ||
Assert.True(modelString != null); | ||
// Compare native LightGBM's and ML.NET's LightGBM results example by example | ||
for (int i = 0; i < _rowNumber; ++i) | ||
{ | ||
double sum = 0; | ||
for (int j = 0; j < _classNumber; ++j) | ||
{ | ||
Assert.Equal(nativeResult0[j + i * _classNumber], mlnetPredictions[i].Score[j], 6); | ||
sum += Math.Exp((float)nativeResult1[j + i * _classNumber]); | ||
} | ||
for (int j = 0; j < _classNumber; ++j) | ||
{ | ||
double prob = Math.Exp(nativeResult1[j + i * _classNumber]); | ||
Assert.Equal(prob / sum, mlnetPredictions[i].Score[j], 6); | ||
} | ||
} | ||
|
||
Done(); | ||
} | ||
|
||
[LightGBMFact] | ||
public void LightGbmInDifferentCulture() | ||
{ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is getting mapped to is_unbalance 🔗︎, default = false, type = bool, aliases: unbalance, unbalanced_sets #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind I see it now:
public static string GetOptionName(string name)
{
// Otherwise convert the name to the light gbm argument
StringBuilder strBuf = new StringBuilder();
bool first = true;
foreach (char c in name)
{
if (char.IsUpper(c))
{
if (first)
first = false;
else
strBuf.Append('_');
strBuf.Append(char.ToLower(c));
}
else
strBuf.Append(c);
}
return strBuf.ToString();
}
In reply to: 299023864 [](ancestors = 299023864)