-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft.Extensions.ML integration package. #3827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package makes it easier to use ML.NET with app models that support Microsoft.Extensions - i.e. ASP.NET and Azure Functions. Specifically it contains functionality for: - Dependency Injection - Pooling PredictionEngines - Reloading models when the file or URI has changed - Hooking ML.NET logging to Microsoft.Extensions.Logging Fix dotnet#3239
Format the code so lines aren't so long. Remove unnecessary IPredictionEnginePoolBuilder interface, and just use a regular class.
wschin
reviewed
Jun 6, 2019
wschin
reviewed
Jun 6, 2019
wschin
reviewed
Jun 6, 2019
wschin
reviewed
Jun 6, 2019
wschin
reviewed
Jun 6, 2019
wschin
reviewed
Jun 6, 2019
wschin
reviewed
Jun 6, 2019
glennc
reviewed
Jun 7, 2019
codemzs
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for @wschin 's comment on MLContext wrapping. Please resolve with him before checking in.
wschin
reviewed
Jun 12, 2019
wschin
approved these changes
Jun 12, 2019
Rename MLContextOptions to MLOptions. Make MLContext lazy loaded, so callers can provide their own. Use the loaded model in the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package makes it easier to use ML.NET with app models that support Microsoft.Extensions - i.e. ASP.NET and Azure Functions.
Specifically it contains functionality for:
Fix #3239
cc @glennc - Note that the only major change I made to your code was to remove the
IPredictionEnginePoolBuilder
interface in favor of using a simple class instead.After this is merged to master, we can remove the
features/IntegrationPackage
branch.