Fix TextLoader constructor and add exception message #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
reviewed
May 30, 2019
wschin
reviewed
May 30, 2019
|
I realize I need to use starts with, since the new line characters change for ubuntu/mac, which is what is causing the test failures. |
yaeldekel
reviewed
May 31, 2019
wschin
reviewed
Jun 5, 2019
src/Microsoft.ML.Data/DataLoadSave/Text/TextLoaderSaverCatalog.cs
Outdated
Show resolved
Hide resolved
yaeldekel
reviewed
Jun 5, 2019
src/Microsoft.ML.Data/DataLoadSave/Text/TextLoaderSaverCatalog.cs
Outdated
Show resolved
Hide resolved
wschin
approved these changes
Jun 5, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3705.
In issue #3705 it appeared that the class defining the data was required to have both get and set auto-properties. In
TextLoaderhowever, we don't use the set property, so I removed that from the conditions.Second, I added an exception message in case no public readable property or field is found in the class defining the data and no dataSample is passed to the constructor.
I added a related test which tests the various scenarios.