Fix to the official build (API Compat tool) #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
reviewed
May 6, 2019
| @@ -24,8 +24,7 @@ | |||
| <!-- API Compat --> | |||
| <PropertyGroup> | |||
| <RunApiCompat Condition="'$(RunApiCompat)' == ''">$(IsStableProject)</RunApiCompat> | |||
| <ToolHostCmd Condition="'$(OS)' != 'Windows_NT'">$(ToolsDir)dotnetcli/dotnet</ToolHostCmd> | |||
There was a problem hiding this comment.
Oh, that's interesting. So we were assuming that if it was windows, then we wouldn't need to use the tools directory. Fun stuff. 😄
There was a problem hiding this comment.
Yes, on the CI windows machines most likely it was installed by default, but not on the official build machines.
TomFinley
approved these changes
May 6, 2019
ericstj
approved these changes
May 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #3667 +/- ##
==========================================
- Coverage 72.78% 72.68% -0.11%
==========================================
Files 808 805 -3
Lines 145588 145533 -55
Branches 16250 16250
==========================================
- Hits 105964 105776 -188
- Misses 35202 35335 +133
Partials 4422 4422
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3623 breaks the official build because the .Net Core 2.1 runtime is not found.
We have it locally in the tools directory, so a solution is to make it point to that local installation of the runtime.
Fixes #3666.