-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rename HalLearners assembly and nuget to Microsoft.ML.Mkl.Components. #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<Project DefaultTargets="Pack"> | ||
|
||
<Import Project="Microsoft.ML.Mkl.Components.nupkgproj" /> | ||
|
||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,23 @@ internal sealed partial class ModelLoadContext : IDisposable | |
public const string ModelStreamName = "Model.key"; | ||
internal const string NameBinary = "Model.bin"; | ||
|
||
/// <summary> | ||
/// Returns the new assembly name to maintain backward compatibility. | ||
/// </summary> | ||
private string ForwardedLoaderAssemblyName | ||
codemzs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
get | ||
{ | ||
switch (LoaderAssemblyName) | ||
{ | ||
case "Microsoft.ML.HalLearners": | ||
return "Microsoft.ML.Mkl.Components"; | ||
default: | ||
return LoaderAssemblyName; | ||
} | ||
} | ||
} | ||
|
||
/// <summary> | ||
/// Return whether this context contains a directory and stream for a sub-model with | ||
/// the indicated name. This does not attempt to load the sub-model. | ||
|
@@ -259,7 +276,7 @@ private void EnsureLoaderAssemblyIsRegistered(ComponentCatalog catalog) | |
{ | ||
if (!string.IsNullOrEmpty(LoaderAssemblyName)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It may have been more sensible to do |
||
{ | ||
var assembly = Assembly.Load(LoaderAssemblyName); | ||
var assembly = Assembly.Load(ForwardedLoaderAssemblyName); | ||
catalog.RegisterAssembly(assembly); | ||
} | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.