Respect group id in options for ranking task #2742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
requested review from
abgoswam,
sfilipi,
codemzs and
najeeb-kazmi
and removed request for
abgoswam and
sfilipi
Codecov Report
@@ Coverage Diff @@
## master #2742 +/- ##
=========================================
Coverage ? 71.67%
=========================================
Files ? 808
Lines ? 142280
Branches ? 16140
=========================================
Hits ? 101978
Misses ? 35862
Partials ? 4440
|
singlis
reviewed
Feb 26, 2019
| @@ -115,7 +115,8 @@ public void FastTreeRankerEstimator() | |||
| new FastTreeRankingTrainer.Options | |||
| { | |||
| FeatureColumn = "NumericFeatures", | |||
| NumTrees = 10 | |||
| NumTrees = 10, | |||
| GroupIdColumn = "Group" | |||
There was a problem hiding this comment.
GroupIdColumn [](start = 20, length = 13)
I feel like this should be "GroupColumn" to fall more inline with FeatureColumn and LabelColumn.
singlis
reviewed
Feb 26, 2019
| @@ -163,7 +164,7 @@ private protected virtual void CheckDataValid(IChannel ch, RoleMappedData data) | |||
| ch.CheckParam(data.Schema.Label.HasValue, nameof(data), "Need a label column"); | |||
| } | |||
|
|
|||
| protected virtual void GetDefaultParameters(IChannel ch, int numRow, bool hasCategarical, int totalCats, bool hiddenMsg=false) | |||
| protected virtual void GetDefaultParameters(IChannel ch, int numRow, bool hasCategarical, int totalCats, bool hiddenMsg = false) | |||
There was a problem hiding this comment.
hasCategarical [](start = 82, length = 14)
misspelling -- should be hasCategorical.
singlis
reviewed
Feb 26, 2019
| @@ -163,7 +164,7 @@ private protected virtual void CheckDataValid(IChannel ch, RoleMappedData data) | |||
| ch.CheckParam(data.Schema.Label.HasValue, nameof(data), "Need a label column"); | |||
| } | |||
|
|
|||
| protected virtual void GetDefaultParameters(IChannel ch, int numRow, bool hasCategarical, int totalCats, bool hiddenMsg=false) | |||
| protected virtual void GetDefaultParameters(IChannel ch, int numRow, bool hasCategarical, int totalCats, bool hiddenMsg = false) | |||
There was a problem hiding this comment.
hiddenMsg [](start = 118, length = 9)
for the sake of not having short names -hiddenMessage?
There was a problem hiding this comment.
I'll leave that stuff to whoever would scrub lightgbm learners.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2652