Remove MD5Hasher. #2706
Merged
Remove MD5Hasher. #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
==========================================
+ Coverage 71.59% 71.64% +0.04%
==========================================
Files 805 804 -1
Lines 142004 141880 -124
Branches 16119 16111 -8
==========================================
- Hits 101672 101651 -21
+ Misses 35892 35792 -100
+ Partials 4440 4437 -3
|
glebuk
reviewed
Feb 23, 2019
| @@ -254,8 +254,6 @@ public sealed class FeatureEvaluator | |||
|
|
|||
| public int Id { get; } | |||
|
|
|||
| public MD5Hash ContentMD5Hash => MD5Hasher.Hash(Content); | |||
There was a problem hiding this comment.
ContentMD5Hash [](start = 27, length = 14)
Looks like the only place using it is DatasetBinFile3 in internal codebase. @TomFinley - ok to remove?
|
I know @eerhardt had some interest in this, mentioning him as informational. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2696