Skip to content

Change Default Settings in TextLoader #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 22, 2019
Merged

Change Default Settings in TextLoader #2630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7034a09
Use AllowSparse=false as default in TextLoader
wschin Feb 19, 2019
e954b86
Update entry point catelog
wschin Feb 19, 2019
39beedd
Make quote- default
wschin Feb 19, 2019
1cabfff
TextLoader uses TextLoader's default settings
wschin Feb 19, 2019
a537d53
Address comments
wschin Feb 21, 2019
fdd08cf
tab to \t
wschin Feb 22, 2019
efe8019
Revert a weird change
wschin Feb 22, 2019
e880f3b
Address comments
wschin Feb 22, 2019
7ce8a5d
Reorder arguments
wschin Feb 22, 2019
ddf3a10
Polish cookbook
wschin Feb 22, 2019
36829ab
Reorder arguments in static TextLoader
wschin Feb 22, 2019
dd29269
Also change argument order in F#
wschin Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert a weird change
  • Loading branch information
@wschin
wschin committed Feb 22, 2019
commit efe8019ec5581104b0595b46d9a4fc8e79bde1eb
1 change: 0 additions & 1 deletion src/Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,6 @@ private static bool TryParseSchema(IHost host, IMultiStreamSource files,
HeaderFile = options.HeaderFile,
MaxRows = options.MaxRows
});
tmp = Regex.Replace(tmp, @"[(sparse=\+)|(quote\+)]", "");

// Try to get the schema information from the file.
string str = Cursor.GetEmbeddedArgs(files);
Expand Down
8 changes: 4 additions & 4 deletions test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3859,8 +3859,8 @@ public void TestSimpleExperiment()
'UseThreads': true,
'HeaderFile': null,
'MaxRows': null,
'AllowQuoting': true,
'AllowSparse': true,
'AllowQuoting': false,
'AllowSparse': false,
'InputSize': null,
'Separator': [
'\t'
Expand Down Expand Up @@ -3922,8 +3922,8 @@ public void TestSimpleTrainExperiment()
'UseThreads': true,
'HeaderFile': null,
'MaxRows': null,
'AllowQuoting': true,
'AllowSparse': true,
'AllowQuoting': false,
'AllowSparse': false,
'InputSize': null,
'Separator': [
'\t'
Expand Down