-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Separate assemblies for static extensions #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Zruty0 . I have created the assemblies (to host static API extensions) so they correspond to nuget packages having the Microsoft.ML prefix. It would be great if you could take a look. |
|
||
namespace Microsoft.ML.OnnxTransform.StaticPipe | ||
{ | ||
public static class DnnImageFeaturizerStaticExtensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public [](start = 4, length = 6)
ideally would want to document, but i get this is low-pri. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap. low-pri .
not looking to modify documentation in this PR
In reply to: 242805885 [](ancestors = 242805885)
I think this one should get moved to StaticPipe too. This is a bit trickier: it is a partial class and therefore on the same namespace as the Text Loader. #Closed Refers to: test/Microsoft.ML.Tests/Transformers/TextFeaturizerTests.cs:37 in a94d7f4. [](commit_id = a94d7f4, deletion_comment = False) |
I am thinking of keeping the TextLoader changes as a separate PR. As you noted, it seems a bit more involved This PR is for the transforms / learners In reply to: 448489458 [](ancestors = 448489458) Refers to: test/Microsoft.ML.Tests/Transformers/TextFeaturizerTests.cs:37 in a94d7f4. [](commit_id = a94d7f4, deletion_comment = False) |
@@ -21,6 +21,7 @@ | |||
using System.Linq; | |||
using Xunit; | |||
using Xunit.Abstractions; | |||
using Microsoft.ML.StaticPipe; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using [](start = 0, length = 5)
sort usings #Resolved
Looks good to me with minor comments. I noticed that we don't yet create NuGet packages for the new static pipe assemblies. Should we do it now (maybe even in this PR), or wait? @TomFinley do you have an opinion? In reply to: 448452854 [](ancestors = 448452854) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1695
NOTE: These assemblies are named corresponding to nuget packages (with the Microsoft.ML prefix)