Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TextLoader.Create in unit test TensorFlowTransformCifarSavedModel #1025

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

abgoswam
Copy link
Member

Fixes a build break in master cause by two commits #853 and #970 that went in almost at the same time

(the two commits work fine by themselves, but there is a dependency between them which caused master to fail)

The fix is to use TextLoader.Create instead of env.CreateLoader("Text...")

Copy link
Contributor

@zeahmed zeahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up @abgoswam !

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka Ivanidzo4ka merged commit 330aa41 into dotnet:master Sep 25, 2018
@abgoswam abgoswam deleted the abgoswam/unblock_build branch November 2, 2018 21:07
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants