Skip to content

Replace usages of TPL DataFlow BufferBlock with Threading.Channels #4482

New issue
New issue
Closed
Closed
Replace usages of TPL DataFlow BufferBlock with Threading.Channels#4482

Description

@eerhardt

eerhardt
openedon Nov 15, 2019

There are 2 places we are using BufferBlock<T> today:

machinelearning/src/Microsoft.ML.Data/Transforms/RowShufflingTransformer.cs

Lines 486 to 487 in b7db4fa

private readonly BufferBlock<int> _toProduce;
private readonly BufferBlock<int> _toConsume;

machinelearning/src/Microsoft.ML.Sweeper/AsyncSweeper.cs

Line 171 in b7db4fa

private readonly BufferBlock<ParameterSetWithId> _paramQueue;

We should consider replacing this dependency with https://www.nuget.org/packages/System.Threading.Channels/ instead. Channels are a bit simpler, and more performant than BufferBlock.

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    P2Priority of the issue for triage purpose: Needs to be fixed at some point.good first issueGood for newcomersup-for-grabsA good issue to fix if you are trying to contribute to the project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions