-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
enhancementNew feature or requestNew feature or requestneed infoThis issue needs more info before triageThis issue needs more info before triageup-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project
Description
Optimize the FactorizationMachinesNative.cpp, by:
1- switching the control variables of the for loops from post-increment to pre-increment, to avoid the extra storage
2- Optimize the intermediate calculations on the current tight loops for better performance.
Example:
for (int fprime = 0; fprime < m; fprime++)
{
const int vBias = j * m * d + fprime * d;
const int qBias = f * m * d + fprime * d;
3- Potentially substitute AlignedArray with a regular array. See the discussion on PR #383
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestneed infoThis issue needs more info before triageThis issue needs more info before triageup-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project