-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
P2Priority of the issue for triage purpose: Needs to be fixed at some point.Priority of the issue for triage purpose: Needs to be fixed at some point.good first issueGood for newcomersGood for newcomersup-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project
Description
One of the extension methods for FeaturizeText needs both the outputColumnName and the inputColumnNames to be provided.
There is no compile error if inputColumnNames is not provided, only a runtime error.
We should fix the error so that when inputColumnNames is not provided, it is set to new[] { outputColumnName } as we do everywhere else in the code base.
machinelearning/src/Microsoft.ML.Transforms/Text/TextCatalog.cs
Lines 60 to 65 in c3bdaaa
| public static TextFeaturizingEstimator FeaturizeText(this TransformsCatalog.TextTransforms catalog, | |
| string outputColumnName, | |
| TextFeaturizingEstimator.Options options, | |
| params string[] inputColumnNames) | |
| => new TextFeaturizingEstimator(Contracts.CheckRef(catalog, nameof(catalog)).GetEnvironment(), | |
| outputColumnName, inputColumnNames, options); |
justinormont
Metadata
Metadata
Assignees
Labels
P2Priority of the issue for triage purpose: Needs to be fixed at some point.Priority of the issue for triage purpose: Needs to be fixed at some point.good first issueGood for newcomersGood for newcomersup-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project