-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Description
The HideEnumValueAttribute
is currently only respected by the command line help tool. Here is an example of it:
machinelearning/src/Microsoft.ML.Transforms/NAHandleTransform.cs
Lines 45 to 52 in c023727
[HideEnumValue] | |
Def = DefaultValue, | |
[HideEnumValue] | |
Default = DefaultValue, | |
[HideEnumValue] | |
Min = Minimum, | |
[HideEnumValue] | |
Max = Maximum, |
Yet in the entry-point manifest I see is polluted with these shorter forms. I feel like these probably ought to be suppressed here during manifest generation as well.
machinelearning/test/BaselineOutput/Common/EntryPoints/core_manifest.json
Lines 15620 to 15632 in 20099c3
"Name": "ReplaceWith", | |
"Type": { | |
"Kind": "Enum", | |
"Values": [ | |
"Default", | |
"Def", | |
"DefaultValue", | |
"Mean", | |
"Minimum", | |
"Min", | |
"Maximum", | |
"Max" | |
] |
Also the entry-point based API is affected by the same issue, of course.
machinelearning/src/Microsoft.ML/CSharpApi.cs
Lines 11162 to 11169 in 20099c3
Default = 0, | |
Def = 0, | |
DefaultValue = 0, | |
Mean = 1, | |
Minimum = 2, | |
Min = 2, | |
Maximum = 3, | |
Max = 3 |
Metadata
Metadata
Assignees
Labels
No labels