Should entry-points respect `HideEnumValueAttribute` information?

The `HideEnumValueAttribute` is currently only respected by the command line help tool. Here is an example of it:

https://github.com/dotnet/machinelearning/blob/c023727b76970ab913ec1ce38276508835c17bcf/src/Microsoft.ML.Transforms/NAHandleTransform.cs#L45-L52

Yet in the entry-point manifest I see is polluted with these shorter forms. I feel like these *probably* ought to be suppressed here during manifest generation as well.

https://github.com/dotnet/machinelearning/blob/20099c31a9ca2d9c50eff299b8ce6f7be5d72346/test/BaselineOutput/Common/EntryPoints/core_manifest.json#L15620-L15632

Also the entry-point based API is affected by the same issue, of course.

https://github.com/dotnet/machinelearning/blob/20099c31a9ca2d9c50eff299b8ce6f7be5d72346/src/Microsoft.ML/CSharpApi.cs#L11162-L11169

	[HideEnumValue]
	Def = DefaultValue,
	[HideEnumValue]
	Default = DefaultValue,
	[HideEnumValue]
	Min = Minimum,
	[HideEnumValue]
	Max = Maximum,

	"Name": "ReplaceWith",
	"Type": {
	"Kind": "Enum",
	"Values": [
	"Default",
	"Def",
	"DefaultValue",
	"Mean",
	"Minimum",
	"Min",
	"Maximum",
	"Max"
	]

	Default = 0,
	Def = 0,
	DefaultValue = 0,
	Mean = 1,
	Minimum = 2,
	Min = 2,
	Maximum = 3,
	Max = 3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Should entry-points respect `HideEnumValueAttribute` information? #341

TomFinley
openedon Jun 9, 2018

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Should entry-points respect HideEnumValueAttribute information? #341

Description

TomFinleyopenedon Jun 9, 2018

Metadata