Skip to content

Make trainer input arguments' names consistent #2680

Closed
@shmoradims

Description

@shmoradims

Just by looking at StandardLearnersCatalog.cs I found a lot of inconsistent naming for the binary classification trainer arguments.

Below are the many naming variations that need to be conflated (both in extension method signatures and the Options properties):

  • labelColumnName, labelColumn
  • featureColumnName, featureColumn
  • weightColumnName, weights
  • initLearningRate, learningRate
  • l2Weight, l2Const, l2RegularizerWeight
  • l1Threshold, l1Weight
  • numIterations, maxIterations
  • lossFunction, loss
  • numIterations, NumberOfIterations

I haven't checked yet, but it's probably the case for other trainers. There's probably more of these inconsistencies.

Metadata

Metadata

Assignees

Labels

APIIssues pertaining the friendly API

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions