This repository was archived by the owner on Mar 15, 2022. It is now read-only.
Exclude Generics\Exceptions test cases that have failures with LLILC #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 Generics\Exceptions test cases were added to CoreCLR in dotnet/coreclr#839. 12 of them have failures with LLILC. Exclude them. Issue dotnet#513 is created for investigation.
|
@AndyAyersMS PTAL |
|
LGTM. I assume from the names that these all throw exceptions and that is why they all fail, but we should take a look and confirm. |
|
retest this please |
libengu
pushed a commit
that referenced
this pull request
Apr 27, 2015
Exclude Generics\Exceptions test cases that have failures with LLILC
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12 Generics\Exceptions test cases were added to CoreCLR in dotnet/coreclr#839.
12 of them have failures with LLILC. Exclude them. Issue #513 is created for investigation.
This PR is supposed to be retested after CoreCLR PR dotnet/coreclr#839 is merged.