Add tests for type deconstruction and construction

test/ILLink.RoslynAnalyzer.Tests/DataFlowTests.cs

@@ -100,6 +100,12 @@ public Task CompilerGeneratedCodeAccessedViaReflection ()
 			return RunTest ();
 		}
 
+		[Fact]
+		public Task ConstructedTypesDataFlow ()
+		{
+			return RunTest ();
+		}
+
 		[Fact]
 		public Task DynamicDependencyDataflow ()
 		{

test/Mono.Linker.Tests.Cases/DataFlow/ConstructedTypesDataFlow.cs

@@ -0,0 +1,194 @@
+// Copyright (c) .NET Foundation and contributors. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Mono.Linker.Tests.Cases.Expectations.Assertions;
+using Mono.Linker.Tests.Cases.Expectations.Helpers;
+
+namespace Mono.Linker.Tests.Cases.DataFlow
+{
+	[ExpectedNoWarnings]
+	[SkipKeptItemsValidation]
+	class ConstructedTypesDataFlow
+	{
+		public static void Main ()
+		{
+			DeconstructedVariable.Test ();
+			ConstructedVariable.Test ();
+		}
+
+		class DeconstructedVariable
+		{
+			// https://github.com/dotnet/linker/issues/3158
+			[ExpectedWarning ("IL2077", ProducedBy = ProducedBy.Trimmer | ProducedBy.NativeAot)]
+			static void DeconstructVariableNoAnnotation ((Type type, object instance) input)
+			{
+				var (type, instance) = input;
+				type.RequiresPublicMethods ();
+			}
+
+			record TypeAndInstance (
+				[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
+				[property: DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
+				Type type,
+				object instance);
+
+			// In IL based tools this is a behavior of the compiler. The attribute on the record declaration parameter
+			// is only propagated to the .ctor constructor parameter. The property and field attributes are applied to the
+			// generated property and field respectively. But none of the attributes is propagated to the Deconstruct method parameters.
+			// For analyzer, this is currently
+			// https://github.com/dotnet/linker/issues/3158
+			//   But it's possible that with that fixed there won't be a warning from the analyzer anyway (depends on the implementation)
+			[ExpectedWarning ("IL2067", ProducedBy = ProducedBy.Trimmer | ProducedBy.NativeAot)]
+			static void DeconstructRecordWithAnnotation (TypeAndInstance value)
+			{
+				var (type, instance) = value;
+				type.RequiresPublicMethods ();
+			}
+
+			class TypeAndInstanceManual
+			{
+				[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
+				public Type type;
+				public object instance;
+
+				public TypeAndInstanceManual ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] Type type, object instance)
+					=> (this.type, this.instance) = (type, instance);
+
+				public void Deconstruct ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] out Type type, out object instance)
+					=> (type, instance) = (this.type, this.instance);
+			}
+
+			// This case actually works because the annotation is correctly propagated through the Deconstruct
+			static void DeconstructClassWithAnnotation (TypeAndInstanceManual value)
+			{
+				var (type, instance) = value;
+				type.RequiresPublicMethods ();
+			}
+
+			record TypeAndInstanceRecordManual (
+				[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
+				[property: DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
+				Type type,
+				object instance)
+			{
+				// The generated property getter doesn't have the same attributes???
+				// The attributes are only propagated to the generated .ctor - so suppressing the warning the this.type doesn't have the matching annotations
+				//[UnconditionalSuppressMessage ("", "IL2072")]
+				public void Deconstruct ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] out Type type, out object instance)
+					=> (type, instance) = (this.type, this.instance);
+			}
+
+			static void DeconstructRecordManualWithAnnotation (TypeAndInstanceRecordManual value)
+			{
+				var (type, instance) = value;
+				type.RequiresPublicMethods ();
+			}
+
+			// https://github.com/dotnet/linker/issues/3158
+			[ExpectedWarning ("IL2067", ProducedBy = ProducedBy.Trimmer | ProducedBy.NativeAot)]
+			static void DeconstructRecordManualWithMismatchAnnotation (TypeAndInstanceRecordManual value)
+			{
+				var (type, instance) = value;
+				type.RequiresPublicFields ();
+			}
+
+			public static void Test ()
+			{
+				DeconstructVariableNoAnnotation ((typeof (string), null));
+				DeconstructRecordWithAnnotation (new (typeof (string), null));
+				DeconstructClassWithAnnotation (new (typeof (string), null));
+				DeconstructRecordManualWithAnnotation (new (typeof (string), null));
+				DeconstructRecordManualWithMismatchAnnotation (new (typeof (string), null));
+			}
+		}
+
+		class ConstructedVariable
+		{
+			[ExpectedWarning ("IL2077")]
+			static void ConstructedType ()
+			{
+				var ct = (typeof (string), 1);
+				ct.Item1.RequiresPublicMethods ();
+			}
+
+			[ExpectedWarning ("IL2077")]
+			static void ConstructedTypeNamed ()
+			{
+				(Type Type, int Value) ct = (typeof (string), 1);
+				ct.Type.RequiresPublicMethods ();
+			}
+
+			[ExpectedWarning ("IL2077")]
+			static void ConstructedTypeWithAnnotations ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] Type type)
+			{
+				var ct = (type, 1);
+				ct.Item1.RequiresPublicMethods ();
+			}
+
+			[ExpectedWarning ("IL2072")]
+			static void AnonymousTypeWithoutAnnotations ()
+			{
+				var ct = new {
+					Type = typeof (string),
+					Value = 1
+				};
+
+				ct.Type.RequiresPublicMethods ();
+			}
+
+			[ExpectedWarning ("IL2072")]
+			static void AnonymousTypeWithExplicitTypesWithoutAnnotations ()
+			{
+				var ct = new {
+					Type = typeof (string),
+					Value = 1
+				};
+
+				ct.Type.RequiresPublicMethods ();
+			}
+
+			// Compiler doesn't propagate attributes, only types
+			[ExpectedWarning ("IL2072")]
+			static void AnonymousTypeWithAnnotation ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] Type type)
+			{
+				var ct = new {
+					Type = type,
+					Value = 1
+				};
+
+				ct.Type.RequiresPublicMethods ();
+			}
+
+			record TypeAndValue ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] Type Type, int Value);
+
+			[ExpectedWarning ("IL2067", "typeUnknown")]
+			static void RecordConstruction (
+				[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] Type typeWithPublicMethods,
+				Type typeUnknown)
+			{
+				_ = new TypeAndValue (typeof (string), 1);
+				_ = new TypeAndValue (typeWithPublicMethods, 2);
+				_ = new TypeAndValue (typeUnknown, 3);
+			}
+
+			public static void Test ()
+			{
+				ConstructedType ();
+				ConstructedTypeNamed ();
+				ConstructedTypeWithAnnotations (typeof (string));
+
+				AnonymousTypeWithoutAnnotations ();
+				AnonymousTypeWithExplicitTypesWithoutAnnotations ();
+				AnonymousTypeWithAnnotation (typeof (string));
+
+				RecordConstruction (typeof (string), typeof (string));
+			}
+		}
+	}
+}