Skip to content

Reset code analysis version in Analyzers #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Reset code analysis version in Analyzers #2969

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92214de
Revert analyzer to lower CodeAnalysis version
jtschuster Aug 11, 2022
ce905b6
Reset Analyzers to the same CodeAnalysis version as everything else
jtschuster Aug 11, 2022
c791b51
Merge branch 'main' into resetCodeAnalysisVersion
jtschuster Aug 12, 2022
b29b3d8
Reset analyzer CodeAnalysis version
jtschuster Aug 12, 2022
fa334be
Merge branch 'main' of https://github.com/dotnet/linker into resetCod…
jtschuster Nov 3, 2022
6deded8
Re-add static-cs
jtschuster Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@

<ItemGroup>
<None Include="Microsoft.NET.ILLink.Analyzers.props" CopyToOutputDirectory="PreserveNewest" />
<!-- The repo CodeAnalyis version is ahead of what is shipped with Visual Studio, so that version breaks the analyzers when used in .Net Framework builds -->
<!-- Once Visual Studio ships with a version >= $(MicrosoftCodeAnalysisVersion), this should be changed to use the property -->
<!-- The repo CodeAnalyis version may be ahead of what is shipped with Visual Studio, so that version may break the analyzers when used in .Net Framework builds -->
<!-- If this happens, pin the version of Microsoft.CodeAnalysis.CSharp here, but not in source-build -->
<PackageReference Condition="'$(DotNetBuildFromSource)' != 'true'" Include="Microsoft.CodeAnalysis.CSharp" Version="$(MicrosoftCodeAnalysisVersion)" PrivateAssets="all" />
<!-- Source-build must always build with the $(MicrosoftCodeAnalysisVersion) to prevent introducing prebuilts. -->
<PackageReference Condition="'$(DotNetBuildFromSource)' != 'true'" Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0-2.final" PrivateAssets="all" />
<PackageReference Condition="'$(DotNetBuildFromSource)' == 'true'" Include="Microsoft.CodeAnalysis.CSharp" Version="$(MicrosoftCodeAnalysisVersion)" PrivateAssets="all" />
<PackageReference Condition="'$(DotNetBuildFromSource)' != 'true'" Include="StaticCs" Version="$(StaticCsVersion)">
<PrivateAssets>all</PrivateAssets>
Expand Down