Fix headers in new files #2716
Merged
Fix headers in new files #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
approved these changes
Apr 1, 2022
Member
|
Thanks for catching this! Is this check not run on all PRs before they merge? |
Contributor
It does but your CI run, ran before the change was merged. Unless running a second time it wouldn't be possible to detect. Sorry for not informing you before |
tlakollo
approved these changes
Apr 1, 2022
Member
Author
|
This can happen because PRs run against a merge commit that's created against main at the time that the PR is made. If main is later updated, the PRs don't get re-run on a new merge commit. Sometimes that kind of situation is caught by merge conflicts, but sometimes (like here) there's no visible merge conflict. |
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Commit migrated from dotnet/linker@49e147b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes new headers which were causing the build to fail after 4f0d349.